Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "have X want Y" error with additional file and line information #42841

Open
raspi opened this issue Nov 26, 2020 · 1 comment
Open

Improve "have X want Y" error with additional file and line information #42841

raspi opened this issue Nov 26, 2020 · 1 comment
Assignees
Milestone

Comments

@raspi
Copy link

@raspi raspi commented Nov 26, 2020

What version of Go are you using (go version)?

go1.15.5 linux/amd64

Does this issue reproduce with the latest release?

Yes

What did you do?

package main

type S interface {
	DoSomething() (int, error)
}

type myS struct{}

func (s myS) DoSomething() (string, error) {
	return ``, nil
}

func main() {
	var _ S = &myS{}
}

What did you expect to see?

Show also line information (foo.go:123:57) for have line. The implementation might be in completely different file. In modern IDEs you simply can click the file information line to navigate to referenced file and line quickly.

want could also have line information to referenced interface definition line?

./prog.go:14:6: cannot use &myS literal (type *myS) as type S in assignment:
	*myS does not implement S (wrong type for DoSomething method)
		have DoSomething() (string, error) at ./prog.go:9:28
		want DoSomething() (int, error)

What did you see instead?

./prog.go:14:6: cannot use &myS literal (type *myS) as type S in assignment:
	*myS does not implement S (wrong type for DoSomething method)
		have DoSomething() (string, error)
		want DoSomething() (int, error)
@networkimprov
Copy link

@networkimprov networkimprov commented Dec 5, 2020

cc @mdempsky @griesemer

Seems overlooked by triage?

@griesemer griesemer added this to the Go1.17 milestone Dec 7, 2020
@griesemer griesemer self-assigned this Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.