all: cleanup ineffectual //go:linkname directives #42938
There are a lot of //go:linkname directives in macOS packages that don't do anything. We should remove them.
To elaborate, a directive like
In CL 273986 (2d6ff99), I removed the occurrences within the standard library, but there are more in the vendored x/sys package that need to be fixed. There might be more instances in other repos too.
To test for problems, you can checkout the
The text was updated successfully, but these errors were encountered:
It's noisy and not doing any harm, and we still have an entire release cycle to revisit and address the issue properly. Updates #42938 Change-Id: I1de5cfb495a8148c9c08b215deba38f2617fb467 Reviewed-on: https://go-review.googlesource.com/c/go/+/274732 Trust: Matthew Dempsky <email@example.com> Run-TryBot: Matthew Dempsky <firstname.lastname@example.org> Reviewed-by: Cuong Manh Le <email@example.com>
For golang/go#42938 Change-Id: I9d68a2436f3ce7402b3c6517a630d0272cf39071 Reviewed-on: https://go-review.googlesource.com/c/sys/+/274573 Trust: Tobias Klauser <firstname.lastname@example.org> Run-TryBot: Tobias Klauser <email@example.com> TryBot-Result: Go Bot <firstname.lastname@example.org> Reviewed-by: Matthew Dempsky <email@example.com>