Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: remove ID dedup code #42956

Closed
jba opened this issue Dec 2, 2020 · 1 comment
Closed

x/pkgsite: remove ID dedup code #42956

jba opened this issue Dec 2, 2020 · 1 comment
Assignees
@jamalc
Labels
NeedsFix pkgsite
Milestone
pkgsite/frontend

Comments

@jba
Copy link
Contributor

@jba jba commented Dec 2, 2020

collectJumpListItemsFallback in content/static/js/jump.js has code to dedup IDs, but there should no longer be duplicate IDs, so the code can be removed.
@jba jba added NeedsFix pkgsite labels Dec 2, 2020
@jba jba added this to the pkgsite/unplanned milestone Dec 2, 2020
@jba jba assigned jamalc Dec 2, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Dec 2, 2020

Change https://golang.org/cl/274954 mentions this issue: content/static/js: remove collectJumpListItemsFallback
@julieqiu julieqiu modified the milestones: pkgsite/unplanned, pkgsite/frontend Dec 2, 2020
@gopherbot gopherbot closed this in golang/pkgsite@557ca0d Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamalc jamalc

Labels
NeedsFix pkgsite
Projects
None yet
Milestone
pkgsite/frontend
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@julieqiu @gopherbot @jamalc @jba