Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/sys/cpu: add support for darwin/arm64 #43046

Open
martisch opened this issue Dec 7, 2020 · 0 comments
Open

x/sys/cpu: add support for darwin/arm64 #43046

martisch opened this issue Dec 7, 2020 · 0 comments
Labels
Milestone

Comments

@martisch
Copy link
Contributor

@martisch martisch commented Dec 7, 2020

darwin/arm64 support for internal/cpu was implemented in c155931 using a mix of dynamic detection with sysctlbyname and hardcoded minimal feature support assumed on darwin/arm64.

For x/sys/cpu it can be assumed it only needs to work with Go 1.16 and newer. Interestingly darwing/arm64 was previosly used for the now ios/arm64 port. We should keep compatibility such that old code still compiles pre Go 1.16 even if there may be no runtime detection supported.

Implementing support for x/sys/cpu will be a bit more complex. While x/sys/cpu does not need to be as low dependency as internal/cpu it should still avoid uncommon or large dependencies. Note that x/sys/cpu is vendored into the standard library for some crypto support that is also vendored in.

x/sys/cpu should avoid a dependency on x/sys/unix: #32102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants