Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: TestTimePprof failure with "profiler refers to ExternalCode" #43118

Closed
bcmills opened this issue Dec 10, 2020 · 8 comments
Closed

runtime: TestTimePprof failure with "profiler refers to ExternalCode" #43118

bcmills opened this issue Dec 10, 2020 · 8 comments
Labels
NeedsFix okay-after-beta1 release-blocker Testing
Milestone
Go1.18

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Dec 10, 2020

2020-12-09T19:12:27-f1980ef/solaris-amd64-oraclerel

--- FAIL: TestTimePprof (0.34s)
    crash_test.go:699: Type: cpu
        Time: Dec 9, 2020 at 9:56pm (CET)
        Duration: 215.70ms, Total samples = 20ms ( 9.27%)
        Showing nodes accounting for 10ms, 50.00% of 20ms total
        Showing top 1 nodes out of 11
              flat  flat%   sum%        cum   cum%
              10ms 50.00% 50.00%       10ms 50.00%  runtime._ExternalCode
    crash_test.go:703: profiler refers to ExternalCode
FAIL
FAIL	runtime	80.082s

See previously #41120.

CC @ianlancetaylor @aclements @tklauser (for TestTimePprof), @hyangah @dmitshur @zikaeroh (in case this is related to CL 275513)
@bcmills bcmills added the NeedsInvestigation label Dec 10, 2020
@bcmills bcmills added this to the Backlog milestone Dec 10, 2020
@bcmills
Copy link
Member Author

@bcmills bcmills commented Feb 25, 2021

2021-02-25T09:20:03-76c0003/solaris-amd64-oraclerel

@bcmills
Copy link
Member Author

@bcmills bcmills commented Nov 19, 2021 •
edited

Looks like there was a substantial uptick in this failure rate in early November.

greplogs --dashboard -md -l -e '(?ms)FAIL: TestTimePprof.*profiler refers to ExternalCode' --since=2021-02-26

2021-11-18T20:11:45-24898d6/solaris-amd64-oraclerel
2021-11-17T18:14:23-9bdbed1/solaris-amd64-oraclerel
2021-11-12T22:20:50-9150c16/solaris-amd64-oraclerel
2021-11-11T19:41:06-f1935c5/solaris-amd64-oraclerel
2021-11-06T00:29:44-b74f2ef/solaris-amd64-oraclerel
2021-11-04T21:33:23-71fc881/solaris-amd64-oraclerel
2021-09-27T20:58:06-e54843f/solaris-amd64-oraclerel

@bcmills bcmills added okay-after-beta1 release-blocker labels Nov 19, 2021
@bcmills bcmills removed this from the Backlog milestone Nov 19, 2021
@bcmills bcmills added this to the Go1.18 milestone Nov 19, 2021
@bcmills
Copy link
Member Author

@bcmills bcmills commented Nov 19, 2021

Marking as release-blocker to either fix the test, or add a skip if the cause is believed to be platform-specific and the fix is non-trivial.

(CC @jeremyfaller)

@jeremyfaller
Copy link
Contributor

@jeremyfaller jeremyfaller commented Nov 19, 2021

CCing @cherrymui as the owner of pprof.

(CCing @prattmic as well, because it's likely he would be interested as well.)

@cherrymui
Copy link
Member

@cherrymui cherrymui commented Nov 19, 2021

Seems this only fails on Solaris? We use libc for syscalls, so the "ExternalCode" may refer to the libc function.

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 24, 2021

@cherrymui I agree. I will send a CL.

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 24, 2021

Change https://golang.org/cl/366759 mentions this issue: runtime: skip TestTimePprof if nanotime calls libc

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 24, 2021

Change https://golang.org/cl/366737 mentions this issue: runtime: skip TestTimePprof on illumos

gopherbot pushed a commit that referenced this issue Nov 24, 2021
@tklauser
runtime: skip TestTimePprof on illumos
7e5331a 
On illumos nanotime calls libc, like on the other systems for which
TestTimePprof is skipped.

For #43118

Change-Id: I370d3f098a261185920cb1e3e3402d16200e301a
Reviewed-on: https://go-review.googlesource.com/c/go/+/366737
Trust: Tobias Klauser <tobias.klauser@gmail.com>
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@dmitshur dmitshur added NeedsFix Testing and removed NeedsInvestigation labels Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix okay-after-beta1 release-blocker Testing
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
6 participants
@dmitshur @jeremyfaller @ianlancetaylor @bcmills @gopherbot @cherrymui