Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: support Windows resource files on windows/arm [freeze exception] #43182

Closed
aclements opened this issue Dec 14, 2020 · 4 comments
Closed

Comments

@aclements
Copy link
Member

@aclements aclements commented Dec 14, 2020

This is a formal freeze exception request for #42866 (which was maybe itself a freeze exception request, but that's not clear at the top).

In Go 1.16, windows/arm support is being revived. However, because of differences in platform tooling used to build Windows resource files, the Go linker is not currently compatible with resource files on windows/arm. Since it's common for Windows Go binaries to link against Windows resource files, it's not currently possible to build many complete Go applications on windows/arm.

@zx2c4 would like to land a series of fairly small changes to the Go linker (summarized here) to support Windows resource files produced by platform tools on windows/arm. We'd like to do this in 1.16 to coincide with the revival of windows/arm support.

cc @golang/release

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Dec 14, 2020

Thank you for making this freeze exception request. We've considered it on the release team and are okay with it.

Approved.

Is your plan to land those changes in time for the beta 1? This issue currently blocks beta 1 (because there isn't an okay-after-beta1 label).

@zx2c4
Copy link
Contributor

@zx2c4 zx2c4 commented Dec 14, 2020

The changes are ready now, as far as I can tell, so as soon as the +2s arrive, I'll submit them.

@aclements
Copy link
Member Author

@aclements aclements commented Dec 14, 2020

We're doing final reviews of @zx2c4 's CLs now. I don't think this has to block beta 1, though.

@gopherbot
Copy link

@gopherbot gopherbot commented Dec 15, 2020

Change https://golang.org/cl/268337 mentions this issue: cmd/link: handle grouped resource sections

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants