Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: illegal character U+0023 '#' #43184

Closed
bep opened this issue Dec 14, 2020 · 3 comments
Closed

runtime: illegal character U+0023 '#' #43184

bep opened this issue Dec 14, 2020 · 3 comments

Comments

@bep
Copy link
Contributor

@bep bep commented Dec 14, 2020

I've seen this in stack traces on test failures both on Windows and MacOS:

       stack:
          D:/a/godartsass/godartsass/transpiler_test.go:129
            c.Check(result.CSS, qt.Equals, fmt.Sprintf("div {\n  color: #%03d;\n}", num))
          C:/hostedtoolcache/windows/go/1.15.5/x64/src/runtime/asm_amd64.s:1374
            <cannot parse source file: C:/hostedtoolcache/windows/go/1.15.5/x64/src/runtime/asm_amd64.s:5:1: illegal character U+0023 '#'>
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Dec 14, 2020

Are you 100% sure that that message is coming from the Go runtime? It looks like you are feeding the stack trace into some other program, and the error is coming from that program.

Loading

@bep
Copy link
Contributor Author

@bep bep commented Dec 14, 2020

Are you 100% sure that that message is coming from the Go runtime?

No I'm not. I just assumed ...

The test framework in question i https://github.com/frankban/quicktest

@frankban or @rogpeppe may know ...

Loading

@rogpeppe
Copy link
Contributor

@rogpeppe rogpeppe commented Dec 15, 2020

This looks like an issue with the stack printing code of quicktest indeed. It attempts to print the source to the failed code, including the entire statement where the failure was found, but it assumes that all file names are Go source, which evidently isn't the case here! It should either print the source line without parsing, or (maybe better) just not print the source at all for non-Go files.

I've created frankban/quicktest#86 to track this, and I'll close this issue because the problem isn't to do with the Go runtime itself.

Loading

@rogpeppe rogpeppe closed this Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants