Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
image/png: invalid format: palette index out of range #4319
What steps will reproduce the problem? 1. Import image/png 2. Attempt to use image.Decode() on certain PNG files 3. Observe error message Code example (and image) - http://play.golang.org/p/cfi12UMcMR What is the expected output? (0,0)-(822,469) What do you see instead? 2012/10/31 01:59:54 png: invalid format: palette index out of range exit status 1 Which compiler are you using (5g, 6g, 8g, gccgo)? 6g Which operating system are you using? Windows 7 Which version are you using? (run 'go version') 1.0.3 Please provide any additional information below. The image attached is an example of error-inducing data. It opens fine in software like Firefox, Chrome and IrfanView, so it would be nice to make it usable in Go as well.
then how do we draw the line between acceptable and unacceptable images? there will be tons of type of invalid images, how should we treat them? i argue that whatever we do with them, the user needs a control, and that unnecessarily complicates the API. i think if you want to write an image editor, and specifically want to deal with bad images, you definitely should apply an extra correction step to them before feeding them to the image package. that said, if we provide an API to retrieve the metadata of an image without parsing them, we can accept images with this kind of defeats. will let nigel to decide.