x/tools/gopls: code action for “add field names to struct literal”

[bcmills]

gopls version
golang.org/x/tools/gopls v0.6.0
    golang.org/x/tools/gopls@v0.6.0-pre.1 h1:i+eJsCS+4N+3YSxLbuq0SrfWim3V8eG4WgdK8xQdzwI=

What did you do?

1. In an emacs buffer, open $GOROOT/src/html/template/template.go:229:
   

   go/src/html/template/template.go

   Lines 228 to 233 in f1980ef

   	ret := &Template{
   	nil,
   	text,
   	text.Tree,
   	t.nameSpace,
   	}

2. M-x eglot-code-actions

What did you expect to see?

An LSP code action that can add field names to the Go struct literal at the current location.

(@stamblerre informs me that VSCode currently provides this functionality using gomodifytags; cc @fatih.)

What did you see instead?

[eglot] No code actions here

[fatih]

What is the expected output for the assignment on line template.go/229 ? I'm not sure how we can add tags here (but maybe I'm missing something). For the record, here are some examples that we support recently: https://github.com/fatih/gomodifytags/releases/tag/v1.13.0

[hyangah]

Based on the title, it sounds like the feature is about transformation to use named fields instead of positional args for struct literals. gomodifytags is to add structure tags, so unrelated.

[bcmills]

Yes, @hyangah has the right intent.

I want the code action to transform the code from

	 ret := &Template{ 
	 	nil, 
	 	text, 
	 	text.Tree, 
	 	t.nameSpace, 
	 } 

to

	 ret := &Template{ 
	 	escapeErr: nil, 
	 	text:      text, 
	 	Tree:      text.Tree, 
	 	nameSpace: t.nameSpace, 
	 } 

[fatih]

Aha I see, thanks for the clarification. I think keyify does this for you (it also has an emacs plugin). In vim-go you can use :GoKeyify

https://github.com/dominikh/go-tools/tree/master/cmd/keyify

[dominikh]

Integrating keyify with gopls is on my todo list. At the same time, gopls already has fillstruct, and I wouldn't be surprised if most of the code required for keyify and fillstruct is identical.