Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: panic: runtime error: slice bounds out of range [::1751306] with length 1048576 [1.15 backport] #43214

Open
gopherbot opened this issue Dec 16, 2020 · 5 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Dec 16, 2020

@thanm requested issue #41621 to be considered for backport to the next 1.15 minor release.

@gopherbot please consider this for backport to 1.15

@thanm
Copy link
Member

@thanm thanm commented Dec 16, 2020

Backport seems reasonable given that this problem exists in Go 1.15 and triggers a panic in the linker.

Worth noting that this problem happens primarily with extremely large packages (more than 1048576 relocations), so primarily an issue for things like machine-generated code.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Dec 16, 2020

Change https://golang.org/cl/278673 mentions this issue: [release-branch.go1.15] cmd/internal/goobj: fix buglet in object file reader

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Dec 30, 2020

Thanks for the request and rationale.

@thanm Is Go 1.14 okay, or does it need a fix for this problem too? Our backport policy is to either fix the bug in all supported Go versions, or none (if it's not very critical).

@thanm
Copy link
Member

@thanm thanm commented Jan 5, 2021

Sorry for the late response -- no need for a 1.14 backport here; the code in question was introduced in 1.15. Thanks.

@toothrot
Copy link
Contributor

@toothrot toothrot commented Jan 7, 2021

Approved as a serious issue with no workaround.

@dmitshur dmitshur modified the milestones: Go1.15.7, Go1.15.8 Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants