Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: floating header obscures printout #43238

Closed
rsc opened this issue Dec 17, 2020 · 3 comments
Closed

x/pkgsite: floating header obscures printout #43238

rsc opened this issue Dec 17, 2020 · 3 comments

Comments

@rsc
Copy link
Contributor

@rsc rsc commented Dec 17, 2020

If you go to a multipage doc like https://pkg.go.dev/github.com/google/go-cmp/cmp and print from Chrome, you can see in the PDF preview that the floating header is printed at the top of every page. Unfortunately, on all but the first page, the floating header is printed on top of actual text that would be useful to be able to read.

If I edit the page with Chrome to make the UnixFixedHeader div "display: none" then the printout is fine. So maybe doing that in print-specific CSS would be enough.

@gopherbot gopherbot added the pkgsite label Dec 17, 2020
@gopherbot gopherbot added this to the Unreleased milestone Dec 17, 2020
@oiooj
Copy link
Member

@oiooj oiooj commented Dec 17, 2020

Yes, and we should also hide DocNavMobile, I'm working on it.

@rsc
Copy link
Contributor Author

@rsc rsc commented Dec 17, 2020

Thanks!

@jba jba added the NeedsFix label Dec 17, 2020
@jba jba modified the milestones: Unreleased, pkgsite/unplanned Dec 17, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Dec 18, 2020

Change https://golang.org/cl/278873 mentions this issue: content/static/css: make pages more printer-friendly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants