Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: 'run file benchmarks' codelens for files without benchmark functions #43239

Closed
hyangah opened this issue Dec 17, 2020 · 1 comment
Closed

Comments

@hyangah
Copy link
Contributor

@hyangah hyangah commented Dec 17, 2020

When enabled the test codelens ("gopls": { "codelenses": { "test": true } }), gopls was sending run file benchmarks codelens for files that don't contain any benchmarks.
Clicking the codelens leads to failure.
Screen Shot 2020-12-16 at 11 36 21 PM

@gopherbot gopherbot added this to the Unreleased milestone Dec 17, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.6.1 Dec 17, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Dec 17, 2020

Change https://golang.org/cl/278780 mentions this issue: internal/lsp/source: only show "run file benchmarks" if available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants