findImports is invoking readGoInfo without info.fset, which apparently is now required to extract imports, so findImports always returns an empty slice. The result is that TestDependencies always passes, and is not actually checking that packages respect the policy.
Marking release-blocker because we might have drifted and grown dependency edges that we don't want.
(Not fixing it because I am supposed to be OOO today.)
Historically the os package has not imported the strings package.
That was enforced by go/build.TestDependencies, but that test
was accidentally broken (#43249). A dependency of os on strings
was accidentally added by CL 266364; remove it.
Trust: Ian Lance Taylor <email@example.com>
Run-TryBot: Ian Lance Taylor <firstname.lastname@example.org>
TryBot-Result: Go Bot <email@example.com>
Reviewed-by: Tobias Klauser <firstname.lastname@example.org>