Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: gopls version output is incorrect #43256

Closed
hyangah opened this issue Dec 18, 2020 · 1 comment
Closed

x/tools/gopls: gopls version output is incorrect #43256

hyangah opened this issue Dec 18, 2020 · 1 comment

Comments

@hyangah
Copy link
Contributor

@hyangah hyangah commented Dec 18, 2020

$ ~/go/bin/gopls version
golang.org/x/tools/gopls v0.6.0
    golang.org/x/tools/gopls@v0.6.1 h1:vD171EDBkyUVyp9B45IYXklV/VEfbHgX0FKw0Q0dO30=

But I am sure I got the latest gopls v0.6.1

$ go version -m ~/go/bin/gopls
/Users/hakim/go/bin/gopls: go1.16beta1
        path    golang.org/x/tools/gopls
        mod     golang.org/x/tools/gopls        v0.6.1  h1:vD171EDBkyUVyp9B45IYXklV/VEfbHgX0FKw0Q0dO30=
        dep     github.com/BurntSushi/toml      v0.3.1
        dep     github.com/google/go-cmp        v0.5.1
        dep     github.com/sergi/go-diff        v1.1.0
        dep     golang.org/x/mod        v0.3.0  h1:RM4zey1++hCTbCVQfnWeKs9/IEsaBLA8vTkd0WVtmH4=
        dep     golang.org/x/sync       v0.0.0-20201020160332-67f06af15bc9      h1:SQFwaSi55rU7vdNs9Yr0Z324VNlrF+0wMqRXT4St8ck=
        dep     golang.org/x/tools      v0.0.0-20201217163546-c88dec5c6b05      h1:4hzTNH658xirWc4MvAx9HK2/2hY6z42i1+lRK8OzeJE=
        dep     golang.org/x/xerrors    v0.0.0-20200804184101-5ec99f83aff1      h1:go1bK/D/BFZV2I8cIQd1NKEZ+0owSTG1fDTci4IqFcE=
        dep     honnef.co/go/tools      v0.0.1-2020.1.6 h1:W18jzjh8mfPez+AwGLxmOImucz/IFjpNlrKVnaj2YVc=
        dep     mvdan.cc/gofumpt        v0.0.0-20200927160801-5bfeb2e70dd6      h1:z+/YqapuV7VZPvBb3GYmuEJbA88M3PFUxaHilHYVCpQ=
        dep     mvdan.cc/xurls/v2       v2.2.0  h1:NSZPykBXJFCetGZykLAxaL6SIpvbVy/UFEniIfHAa8A=
@gopherbot gopherbot added this to the Unreleased milestone Dec 18, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.6.2 Dec 18, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Dec 23, 2020

Change https://golang.org/cl/279715 mentions this issue: gopls/release: add a command to validate the gopls release process

@stamblerre stamblerre added this to Needs Triage in vscode-go: gopls by default via automation Dec 23, 2020
@stamblerre stamblerre moved this from Needs Triage to In progress in vscode-go: gopls by default Dec 23, 2020
@stamblerre stamblerre self-assigned this Dec 24, 2020
gopherbot pushed a commit to golang/tools that referenced this issue Dec 24, 2020
The gopls release process has a number of steps which can be easily
forgotten, but they are also easy enough to check. In the future, we can
certainly automate this process further, but this basic program will
validate that mistakes like golang/go#43256 are not made again in the
future.

Change-Id: I04641ae202bc6615f2e4c8810b5dab4885d37fd4
Reviewed-on: https://go-review.googlesource.com/c/tools/+/279715
Trust: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
@stamblerre stamblerre closed this Dec 31, 2020
vscode-go: gopls by default automation moved this from In progress to Done Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants