Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: Examples are missing the "Output:" label when example output provided #43266

Open
AdRiley opened this issue Dec 18, 2020 · 2 comments
Open

Comments

@AdRiley
Copy link

@AdRiley AdRiley commented Dec 18, 2020

What is the URL of the page with the issue?

https://pkg.go.dev/strings#example-Compare

What is your user agent?

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:84.0) Gecko/20100101 Firefox/84.0

Screenshot

image

What did you do?

Went to the page

What did you expect to see?

The example output labelled as Output: as it is on GoDoc.

image

Without the label it isn't immediately clear what you are looking at.

What did you see instead?

There is no "Output:" label instead the example code and example output are just right next to each other.

@gopherbot gopherbot added the pkgsite label Dec 18, 2020
@gopherbot gopherbot added this to the Unreleased milestone Dec 18, 2020
@AdRiley
Copy link
Author

@AdRiley AdRiley commented Dec 18, 2020

I would like to fix this if that would be OK?

@jba jba modified the milestones: Unreleased, pkgsite/unplanned Dec 18, 2020
@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Dec 21, 2020

/cc @georgehu for UX input

@julieqiu julieqiu added the UX label Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.