Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: convert suggested fix in go list error message to suggested fix #43338

Closed
stamblerre opened this issue Dec 23, 2020 · 1 comment
Closed

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Dec 23, 2020

Some go list error messages look like:

go: github.com/sergi/go-diff@v1.1.0: missing go.sum entry; try 'go mod download github.com/sergi/go-diff' to add it

The try 'go mod download github.com/sergi/go-diff' to add it piece can be very easily parsed and converted to a suggested fix.

@stamblerre stamblerre added this to the gopls/v0.6.2 milestone Dec 23, 2020
@stamblerre stamblerre self-assigned this Dec 23, 2020
@stamblerre stamblerre added this to Needs Triage in vscode-go: gopls by default via automation Dec 23, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Dec 24, 2020

Change https://golang.org/cl/280093 mentions this issue: internal/lsp: restructure the way we report critical errors

@stamblerre stamblerre moved this from Needs Triage to Critical in vscode-go: gopls by default Dec 28, 2020
vscode-go: gopls by default automation moved this from Critical to Done Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants