Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: ExampleFrames with -trimpath fails #43380

Closed
hajimehoshi opened this issue Dec 25, 2020 · 2 comments
Closed

runtime: ExampleFrames with -trimpath fails #43380

hajimehoshi opened this issue Dec 25, 2020 · 2 comments
Milestone

Comments

@hajimehoshi
Copy link
Member

@hajimehoshi hajimehoshi commented Dec 25, 2020

What version of Go are you using (go version)?

$ go version
go version go1.15.2 darwin/amd64

Does this issue reproduce with the latest release?

I believe yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/hajimehoshi/Library/Caches/go-build"
GOENV="/Users/hajimehoshi/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/hajimehoshi/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/hajimehoshi/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/60/khbk2xqn1c5bml1byjn89dwc0000gn/T/go-build113444596=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

Run go test runtime -run=ExampleFrames -trimpath

What did you expect to see?

Pass the test

What did you see instead?

$ go test runtime -run=ExampleFrames -trimpath
--- FAIL: ExampleFrames (0.00s)
got:
- more:true | runtime.Callers
want:
- more:true | runtime.Callers
- more:true | runtime_test.ExampleFrames.func1
- more:true | runtime_test.ExampleFrames.func2
- more:true | runtime_test.ExampleFrames.func3
- more:true | runtime_test.ExampleFrames
FAIL
FAIL    runtime 0.233s
FAIL

The content of frame.File depends on -trimpath. With -trimpath, this starts with runtime_test/ instead of runtime/ and then the test fails.

@gopherbot
Copy link

@gopherbot gopherbot commented Dec 25, 2020

Change https://golang.org/cl/279440 mentions this issue: runtime: Make ExampleFrames pass with -trimpath

Loading

@toothrot toothrot added this to the Backlog milestone Jan 5, 2021
@rsc
Copy link
Contributor

@rsc rsc commented Apr 6, 2021

We should use "runtime.X" instead of "runtime_test.X".
We should also check what happens for package main.

Loading

@gopherbot gopherbot closed this in 117b1c8 Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants