Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: improve command-line UX when checking files outside of the current module #43417

Open
pjweinb opened this issue Dec 29, 2020 · 0 comments
Labels

Comments

@pjweinb
Copy link

@pjweinb pjweinb commented Dec 29, 2020

$ go version
go version go1.15.6 darwin/amd64

To reproduce, in the tools repository:

$ cd gopls
$ gopls check ../internal/lsp/cmd/cmd.go
2020/12/29 08:28:38 Error:2020/12/29 08:28:38 warning: diagnose package: no package for golang.org/x/tools/internal/lsp/cmd
	snapshot=1
	package="golang.org/x/tools/internal/lsp/cmd"

but it never finishes. Contrast this with

$ cd gopls
gopls check main.go

which returns immediately.

@gopherbot gopherbot added this to the Unreleased milestone Dec 29, 2020
@stamblerre stamblerre changed the title x/tools/gopls: gopls check command hangs on package errors x/tools/gopls: improve command-line UX when checking files outside of the module Dec 29, 2020
@stamblerre stamblerre changed the title x/tools/gopls: improve command-line UX when checking files outside of the module x/tools/gopls: improve command-line UX when checking files outside of the current module Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.