Skip to content

x/tools/gopls: improve command-line UX when checking files outside of the current module #43417

@pjweinb

Description

@pjweinb
$ go version
go version go1.15.6 darwin/amd64

To reproduce, in the tools repository:

$ cd gopls
$ gopls check ../internal/lsp/cmd/cmd.go
2020/12/29 08:28:38 Error:2020/12/29 08:28:38 warning: diagnose package: no package for golang.org/x/tools/internal/lsp/cmd
	snapshot=1
	package="golang.org/x/tools/internal/lsp/cmd"

but it never finishes. Contrast this with

$ cd gopls
gopls check main.go

which returns immediately.

Metadata

Metadata

Assignees

No one assigned

    Labels

    ToolsThis label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions