Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/release: darwin/arm64 installer prompts for installing Rosetta 2 #43422

Open
usmannajib opened this issue Dec 29, 2020 · 7 comments
Open
Assignees
Milestone

Comments

@usmannajib
Copy link

@usmannajib usmannajib commented Dec 29, 2020

What version of Go are you using (go version)?

1.16beta1

$ go version

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

MacOS Big Sur on arm64 M1

go env Output
$ go env

What did you do?

Ran installation

What did you expect to see?

The installer should have installed Go in native M1 mode.

What did you see instead?

The installer asked for Rosetta to be installed as a mandatory install dependency.

@cherrymui
Copy link
Contributor

@cherrymui cherrymui commented Dec 29, 2020

Just to be sure, is https://golang.org/dl/go1.16beta1.darwin-arm64.pkg the installer you used?

cc @dmitshur

@usmannajib
Copy link
Author

@usmannajib usmannajib commented Dec 29, 2020

Yes take a look at the screenshot below
image

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Dec 29, 2020

Thanks for reporting. Perhaps there's some configuration in the installer causing macOS to think Rosetta will be needed, when that shouldn't be the case. We'll take a look.

After installing, does go version output end with "darwin/arm64"?
Also, what macOS version did you test with?

@dmitshur dmitshur changed the title Installation asks for installing Rosetta 2 x/build/cmd/release: darwin/arm64 installer prompts for installing Rosetta 2 Dec 29, 2020
@gopherbot gopherbot added the Builders label Dec 29, 2020
@gopherbot gopherbot added this to the Unreleased milestone Dec 29, 2020
@dmitshur dmitshur modified the milestones: Unreleased, Go1.16 Dec 29, 2020
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Dec 29, 2020

The problem may be that we're not including a hostArchitectures property in the installer Distribution options:

$ pkgutil --expand go1.16beta1.darwin-arm64.pkg out
$ cat out/Distribution | grep options
    <options customize="never" allow-external-scripts="no"/>

It likely needs to be set to a value that includes arm64:

<options hostArchitectures="arm64" customize="never" allow-external-scripts="no"/>

CC @golang/release, @markmentovai.

@dmitshur dmitshur self-assigned this Dec 29, 2020
@usmannajib
Copy link
Author

@usmannajib usmannajib commented Dec 30, 2020

I actually didn't install it as I wanted a "pure" experience 😄

I am testing with 11.1

Let me know if it helps to actually install it.

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Dec 30, 2020

Thanks.

We should fix this in time for the next pre-release of Go 1.16. If you'd like, you can wait until then, but you certainly don't have to. This issue affects only the installer, the actual Go distribution is already built for ARM64. You can also use the go1.16beta1.darwin-arm64.tar.gz archive to avoid having to install Rosetta 2.

@usmannajib
Copy link
Author

@usmannajib usmannajib commented Dec 30, 2020

@dmitshur Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.