Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gollvm: runtime/malloc.go, runtime/mgcscavenge.go: error: reference to undefined identifier 'sys.GoosIos' (GCC) #43540

Open
advancedwebdeveloper opened this issue Jan 6, 2021 · 4 comments
Labels
Milestone

Comments

@advancedwebdeveloper
Copy link

@advancedwebdeveloper advancedwebdeveloper commented Jan 6, 2021

Hi.
Automated build, using Github Actions, which uses

gcc (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0

raised these errors:

/home/runner/work/clang_test_cpu_features/clang_test_cpu_features/clang_test_cpu_features/llvm-project/llvm/tools/gollvm/gofrontend/libgo/go/runtime/malloc.go:220:51: error: reference to undefined identifier 'sys.GoosIos'
/home/runner/work/clang_test_cpu_features/clang_test_cpu_features/clang_test_cpu_features/llvm-project/llvm/tools/gollvm/gofrontend/libgo/go/runtime/malloc.go:220:156: error: reference to undefined identifier 'sys.GoosIos'
/home/runner/work/clang_test_cpu_features/clang_test_cpu_features/clang_test_cpu_features/llvm-project/llvm/tools/gollvm/gofrontend/libgo/go/runtime/mgcscavenge.go:93:50: error: reference to undefined identifier 'sys.GoosIos'

@thanm
Copy link
Member

@thanm thanm commented Jan 6, 2021

Thanks. I have a patch in progress for this.

@gopherbot
Copy link

@gopherbot gopherbot commented Jan 7, 2021

Change https://golang.org/cl/281855 mentions this issue: gollvm: add "ios", "zos" to supported GOOS values

@toothrot toothrot added this to the Backlog milestone Jan 8, 2021
lumontec pushed a commit to lumontec/gollvm that referenced this issue Feb 9, 2021
Add "ios" and "zos" to the set of supported GOOS values, now needed as
part of the update of gofrontend to Go1.16beta1.

Updates golang/go#43540.

Change-Id: Ifb5fb281f4fec1aca9f934ceeded4a719728a103
Reviewed-on: https://go-review.googlesource.com/c/gollvm/+/281855
Trust: Than McIntosh <thanm@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants