Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/text: overwriting a previous write #43623

Closed
ondrejbudai opened this issue Jan 11, 2021 · 3 comments
Closed

x/text: overwriting a previous write #43623

ondrejbudai opened this issue Jan 11, 2021 · 3 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@ondrejbudai
Copy link

ondrejbudai commented Jan 11, 2021

This line of code of code has no effect because the value in precedingCharacterType is overridden later.

@gopherbot gopherbot added this to the Unreleased milestone Jan 11, 2021
@davecheney
Copy link
Contributor

@ondrejbudai feel free to send a PR if the tests pass after removing this line

@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 15, 2021
@cagedmantis
Copy link
Contributor

/cc @mpvl

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/358834 mentions this issue: text/unicod/bidi: remove duplicate assignment

SilverRainZ added a commit to SilverRainZ/text that referenced this issue Oct 27, 2021
SilverRainZ added a commit to SilverRainZ/text that referenced this issue Nov 1, 2021
SilverRainZ added a commit to SilverRainZ/text that referenced this issue Nov 2, 2021
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Nov 9, 2021
@dmitshur dmitshur modified the milestones: Unreleased, Go1.18 Nov 9, 2021
xhit pushed a commit to xhit/text that referenced this issue Oct 10, 2022
Fixes golang/go#43623

Change-Id: I4da134cccaf6a9e5331229a0ac2a60e5cb711e92
GitHub-Last-Rev: ae0f2d9
GitHub-Pull-Request: golang#29
Reviewed-on: https://go-review.googlesource.com/c/text/+/358834
Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>
Trust: Marcel van Lohuizen <mpvl@golang.org>
Trust: Ian Lance Taylor <iant@golang.org>
@golang golang locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants