go/build: missing Position information for go:embed patterns #43632
Labels
Milestone
Comments
Marking as release-blocker for Go 1.16 because it impacts However, we could perhaps decide to ship the |
Change https://golang.org/cl/283638 mentions this issue: |
Change https://golang.org/cl/283636 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Jan 14, 2021
For #43469 For #43632 Change-Id: I9ac2da690344935da0e1dbe00b134dfcee65ec8a Reviewed-on: https://go-review.googlesource.com/c/go/+/283636 Run-TryBot: Jay Conrod <jayconrod@google.com> TryBot-Result: Go Bot <gobot@golang.org> Trust: Jay Conrod <jayconrod@google.com> Reviewed-by: Bryan C. Mills <bcmills@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Go 1.16 adds support for
go:embed
patterns in source files (#41191), which are parsed and reported by thego/build
package in the {,Test
,XTest
}EmbedPatterns
fields of thebuild.Package
struct as of CL 243941.Much like imports, embed patterns can introduce errors in the build due to missing inputs — in this case, missing embedded files. Those errors need to be attributed back to source file positions.
For imports, the
build.Package
struct represents the file and line information astoken.Position
values in the {,Test
,XTest
}ImportPos
fields. However, the corresponding information for embed patterns seems not to be present.This came to my attention via CL 280452.
The text was updated successfully, but these errors were encountered: