Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: don't invalidate metadata on didOpen of go.mod #43647

Open
findleyr opened this issue Jan 12, 2021 · 0 comments
Open

x/tools/gopls: don't invalidate metadata on didOpen of go.mod #43647

findleyr opened this issue Jan 12, 2021 · 0 comments
Labels
Milestone

Comments

@findleyr
Copy link
Contributor

@findleyr findleyr commented Jan 12, 2021

This is an extension of #42529, where the solution to reload thrashing while editing the go.mod file was to only invalidate metadata on saves of the go.mod file.

Unfortunately, our invalidation logic treats didOpen notifications nearly identically to saves, as go.mod is in the "changed" set and saved == true. This can cause problems in testing, and I also suspect could be disruptive in some large workspaces where metadata reloading takes many seconds. It's also just counter-intuitive.

Related to #43554.

Not a high priority.

@gopherbot gopherbot added this to the Unreleased milestone Jan 12, 2021
@findleyr findleyr modified the milestones: Unreleased, gopls/v1.0.0 Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.