Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: establishing a hierarchy for the directories section #43694

Closed
jamalc opened this issue Jan 14, 2021 · 2 comments
Closed

x/pkgsite: establishing a hierarchy for the directories section #43694

jamalc opened this issue Jan 14, 2021 · 2 comments
Assignees
@jamalc
Labels
NeedsFix pkgsite
Milestone
pkgsite/unplanned

Comments

@jamalc
Copy link
Member

@jamalc jamalc commented Jan 14, 2021

It can be difficult to see the relationship between nested packages and modules. We're planning to establish a tree-like hierarchy for the directories section to make these relationships more explicit.

  • Paths will be named relative to the current view and grouped by their first part.
  • Directory paths will have a toggle to expand their nested items.
  • Modules and packages will have links to their documentation pages.
  • Module paths will have a 'module' label and no longer be separated from package paths.

Screen Shot 2021-01-14 at 10 53 01 AM
@jamalc jamalc added NeedsFix pkgsite labels Jan 14, 2021
@jamalc jamalc added this to the pkgsite/unplanned milestone Jan 14, 2021
@jamalc jamalc self-assigned this Jan 14, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Jan 14, 2021

Change https://golang.org/cl/283714 mentions this issue: internal/frontend: add nested directories to unit details
@gopherbot
Copy link

@gopherbot gopherbot commented Jan 14, 2021

Change https://golang.org/cl/283715 mentions this issue: content/static: unit directories tree layout
gopherbot pushed a commit to golang/pkgsite that referenced this issue Jan 14, 2021
@jamalc
internal/frontend: add nested directories to unit details
41b428d 
Adds a function to zip subdirectories and nested modules
into a tree structure for use in the unit directories
redesign.

For golang/go#43694

Change-Id: Ib2539681dfa5b69c63949d116dd468f4fdbc89d5
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/283714
Trust: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
gopherbot pushed a commit to golang/pkgsite that referenced this issue Jan 14, 2021
@jamalc
content/static: unit directories tree layout
fad5438 
Updates unit directories section to nest subdirectories
in a two level tree structure.

For golang/go#43694

Change-Id: I374c042234aeb426b24ae44c861bfb61e6511db1
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/283715
Trust: Jamal Carvalho <jamal@golang.org>
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Julie Qiu <julie@golang.org>
@jamalc jamalc closed this Feb 18, 2021
@seankhliao seankhliao mentioned this issue Feb 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamalc jamalc

Labels
NeedsFix pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@gopherbot @jamalc