Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/coordinator: add ability to auto-add slowbots based on filepaths modified in a CL #43719

Open
mdempsky opened this issue Jan 15, 2021 · 3 comments

Comments

@mdempsky
Copy link
Member

@mdempsky mdempsky commented Jan 15, 2021

On the dev.regabi branch, there's naturally a lot of development happening related to the regabi experiment. It would be nice if the linux-amd64-regabi slowbot was automatically included in Trybot runs for that branch.

Similarly, a lot of this work is happening in the SSA backend, and concurrency issues here are only caught on the linux-amd64-racecompile slowbot. It would be nice if this slowbot could either also be added by default for dev.regabi, or maybe for all CLs that touch src/cmd/compile.

I've broken these builders 3 times in the past ~week. 😬

/cc @dmitshur

@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Jan 15, 2021

Loading

@bcmills
Copy link
Member

@bcmills bcmills commented Jan 15, 2021

Compare #42661.

Loading

@dmitshur dmitshur added this to Planned in Go Release Team Apr 28, 2021
@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Apr 28, 2021

I'll retitle this to about adding the ability to opt-in to builders based on files modified in a CL. We need to do some work for it, but it would enable us to improve pre-submit test coverage in a more targeted way than currently possible. It will help make progress on issues like #42661 and #19535.

We already have a mechanism to enable trybots based on branch name by specifying a custom tryBot policy function—no new work is needed for this. @mdempsky If there are TryBot changes that are worth making with branch-name filtering only, please let me know (I suspect the branch situation has changed since this issue was originally filed).

Loading

@dmitshur dmitshur changed the title x/build: auto-add slowbots based on branch / CL contents x/build/cmd/coordinator: add ability to auto-add slowbots based on filepaths modified in a CL Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants