Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: show a page for an empty directory that is above a nested module #43725

Closed
julieqiu opened this issue Jan 15, 2021 · 3 comments
Closed

Comments

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Jan 15, 2021

https://pkg.go.dev/google.golang.org/grpc@v1.35.0/cmd currently returns a 404, because it is a directory in the module google.golang.org/grpc that does not contain any packages.

https://pkg.go.dev/google.golang.org/grpc/cmd/protoc-gen-go-grpc however is a nested module in the parent module, https://pkg.go.dev/google.golang.org/grpc.

It would be useful to show a directory page containing the nested module at https://pkg.go.dev/google.golang.org/grpc@v1.35.0/cmd.

@ya5u
Copy link

@ya5u ya5u commented Feb 1, 2021

@julieqiu I'd like to take this issue

@julieqiu
Copy link
Contributor Author

@julieqiu julieqiu commented Feb 2, 2021

Sounds great - thanks!

@gopherbot
Copy link

@gopherbot gopherbot commented Feb 5, 2021

Change https://golang.org/cl/290049 mentions this issue: internal/frontend: show a page for an empty directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants