Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wiki: CodeReviewComments change #43770

Open
bunyk opened this issue Jan 19, 2021 · 0 comments
Open

wiki: CodeReviewComments change #43770

bunyk opened this issue Jan 19, 2021 · 0 comments

Comments

@bunyk
Copy link
Contributor

@bunyk bunyk commented Jan 19, 2021

Imports section shows example:

import (
	"fmt"
	"hash/adler32"
	"os"

	"appengine/foo"
	"appengine/user"

	"github.com/foo/bar"
	"rsc.io/goversion/version"
)

From which it is not obvious that appengine is third-party package, not stdlib. And this is legacy way to import appengine: https://github.com/golang/appengine#updating-from-legacy-import-appengine-packages

I think this group should be removed from example, or updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants