Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: entire directories section highlighted when clicking on anchor #43773

Closed
julieqiu opened this issue Jan 19, 2021 · 2 comments
Closed

x/pkgsite: entire directories section highlighted when clicking on anchor #43773

julieqiu opened this issue Jan 19, 2021 · 2 comments
Assignees
@jamalc
Labels
NeedsFix pkgsite
Milestone
pkgsite/frontend

Comments

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Jan 19, 2021

What is the URL of the page with the issue?

http://localhost:8080/gocloud.dev#section-directories

(This change hasn't been deployed yet)

Screenshot

Screen Shot 2021-01-19 at 9 23 39 AM

What did you do?

Click on the "Directories" section in the left nav.

What did you expect to see?

Nothing

What did you see instead?

Entire directories section highlighted
@julieqiu julieqiu added NeedsFix pkgsite labels Jan 19, 2021
@julieqiu julieqiu added this to the pkgsite/frontend milestone Jan 19, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Jan 19, 2021

Change https://golang.org/cl/284572 mentions this issue: content/static/css: hide highlight CSS on anchors
gopherbot pushed a commit to golang/pkgsite that referenced this issue Jan 19, 2021
@julieqiu
content/static/css: hide highlight CSS on anchors
6de9ee3 
When visiting a #section-directories anchor tag, the entire section will
turn yellow.

This CSS is commented out for today's deploy.

For golang/go#43773

Change-Id: Ic9c26845203c6518a368ea19af36c42a21958354
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/284572
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
@jamalc jamalc self-assigned this Jan 28, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Jan 28, 2021

Change https://golang.org/cl/287635 mentions this issue: content/static: re-enable target highlighting
@gopherbot gopherbot closed this in golang/pkgsite@7588e3d Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamalc jamalc

Labels
NeedsFix pkgsite
Projects
None yet
Milestone
pkgsite/frontend
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@julieqiu @gopherbot @jamalc