Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: Jump To breaks the page when selecting it after clicking a page link #43804

Open
katiehockman opened this issue Jan 20, 2021 · 3 comments

Comments

@katiehockman
Copy link
Member

@katiehockman katiehockman commented Jan 20, 2021

This bug is kind of hard to explain, but can be repro'd with these steps:

  1. Navigate to https://pkg.go.dev/crypto/rand
  2. Click something in the Index, e.g Prime (the URL should now be https://pkg.go.dev/crypto/rand#Prime)
  3. Click the "Jump to..." (a dialogue should appear)
  4. Press the back button
  5. Note that the box has disappeared but the rest of the page is still greyed-out and non-interactable

/cc @julieqiu

@gopherbot gopherbot added the pkgsite label Jan 20, 2021
@gopherbot gopherbot added this to the Unreleased milestone Jan 20, 2021
@julieqiu julieqiu modified the milestones: Unreleased, pkgsite/frontend Jan 20, 2021
@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Jan 20, 2021

I think the issue is that clicking the back button doesn't close the input box. It just takes me to the top of the page:

Screen Shot 2021-01-20 at 10 20 55 AM

When I scroll to the bottom, the input box is still there:

Screen Shot 2021-01-20 at 10 21 14 AM

/cc @jamalc

@Omkar76
Copy link

@Omkar76 Omkar76 commented Jan 27, 2021

@julieqiu , There have been few changes in css code since this issue was opened.The stylesheet was modified for issue #43840. Now both the .JumpDialog and .ShortcutsDialog stays on viewport. They don't get scrolled away when the screen is scrolled.

So now my question is - is it still necessary to close the input boxes when back button is pressed? because user can now see the boxes even after pressing back button and will know they need to close input box in order to interact with rest of the page.

@georgehu
Copy link
Collaborator

@georgehu georgehu commented Jan 27, 2021

Thanks for flagging this issue @Omkar76. I agree that clicking back should return you to the previous state without a grey overlay or the "jump to" dialog.

CC @julieqiu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants