Gerrit: self-review restriction is unintuitive when cherry-picking #43812
Labels
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
When cherry-picking someone else's change and creating a CL (i.e. https://go-review.googlesource.com/c/go/+/284779/1) the imposed self-review restriction is somewhat confusing. In this case the author of the commit is able to +2 the change, but the owner who uploaded it is it.
This seems reversed, the "owner" did not actually author the commit so they aren't self-reviewing, whereas the "author" did. I think it would make more sense if the owner was able to +2, but the author was not. The person who uploads the CL still needs to get a Trust+1 before they can submit the change, so they would still be prevented from submitting something without any oversight.
The text was updated successfully, but these errors were encountered: