Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website/content/static/doc: install.html doesn't show darwin-arm64.pkg installer to Apple silicon users #43815

Open
dmitshur opened this issue Jan 20, 2021 · 3 comments

Comments

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Jan 20, 2021

When visiting https://golang.org/doc/install on an Apple silicon Mac (tested on Safari and Chrome), that page displays only the darwin-amd64.pkg installer, not darwin-arm64.pkg one:

image

It should either show both, or if possible to tell the two macOS architectures apart, perhaps only the right one.

CC @golang/release, @stevetraut, @julieqiu.

@stevetraut
Copy link

@stevetraut stevetraut commented Jan 21, 2021

I think we should display the one most Mac users are going to use. What is the reason we show some downloads in bold type at the download page?

@dmitshur
Copy link
Contributor Author

@dmitshur dmitshur commented Jan 21, 2021

I think we should display the one most Mac users are going to use.

As Apple goes through the transition over the years, there will be more ARM64 users and fewer AMD64 ones, but I imagine it'll be quite gradual. If we can't dynamically determine what architecture the page viewer has, this seems like a reasonable fallback. We can also consider showing both and letting the user pick.

What is the reason we show some downloads in bold type at the download page?

Some entries are intentionally highlighted in bold type because they are deemed to be more noteworthy (e.g., more commonly used). See the File.Highlight method and its code for more details. It was recently modified in CL 278787 to also highlight the new darwin/arm64 installer.

@matloob
Copy link
Contributor

@matloob matloob commented Feb 17, 2021

Autodetecting would be ideal, but if we can't autodetect, I believe we should have both installers shown.

When I was installing on my mac, I reflexively clicked on the macOS link without reading the small print. Then I realized that I was sent to the wrong binary and had to find the right one on the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants