Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: JumpDialog not staying on viewport after scroll #43840

Closed
Omkar76 opened this issue Jan 22, 2021 · 2 comments
Closed

x/pkgsite: JumpDialog not staying on viewport after scroll #43840

Omkar76 opened this issue Jan 22, 2021 · 2 comments

Comments

@Omkar76
Copy link

@Omkar76 Omkar76 commented Jan 22, 2021

Steps to reproduce the bug:

  • Visit https://pkg.go.dev/crypto/rand
  • Press F (A Modal Dialog will appear with "Jump to" heading)
  • Try scrolling the page. The modal dialog gets scrolled away.

I think ideally it should stay on screen and not get scrolled away.

@Omkar76 Omkar76 changed the title JumpDialog not staying on viewport after scroll x/pkgsite: JumpDialog not staying on viewport after scroll Jan 22, 2021
@gopherbot gopherbot added the pkgsite label Jan 22, 2021
@gopherbot gopherbot added this to the Unreleased milestone Jan 22, 2021
@Omkar76
Copy link
Author

@Omkar76 Omkar76 commented Jan 22, 2021

I tried to tweak with css properties in chrome and found that .JumpDialog class is missing position property (see code here). Also dialog-polyfill.css sets position to absolute (see code here).

position:fixed will solve the issue. I'll send a PR with this changes.

Omkar76 added a commit to Omkar76/pkgsite that referenced this issue Jan 22, 2021
add `position:fixed;` to `.JumpDialog` class to always keep it on visible viewport even if the page is scrolled.
fixes golang/go#43840
@gopherbot
Copy link

@gopherbot gopherbot commented Jan 22, 2021

Change https://golang.org/cl/285674 mentions this issue: content/static/css: make .JumpDialog's position fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants