Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: mismatch between GetLatestMajorPathForV1Path and getLatestMajorVersion #43849

Open
julieqiu opened this issue Jan 22, 2021 · 1 comment

Comments

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Jan 22, 2021

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/mediocregopher/radix

Screenshot

image

What did you do?

Visited https://pkg.go.dev/github.com/mediocregopher/radix and was redirected to https://pkg.go.dev/github.com/mediocregopher/radix/v4. This should redirect to https://pkg.go.dev/github.com/mediocregopher/radix/v3, since that is the highest tagged version.

This is due to a mismatch in the logic between GetLatestMajorPathForV1Path and getLatestMajorVersion. GetLatestMajorPathForV1Path looks for the highest major version, numerically. getLatestMajorVersion takes into account whether the module has tagged versions.

@gopherbot gopherbot added the pkgsite label Jan 22, 2021
@gopherbot gopherbot added this to the Unreleased milestone Jan 22, 2021
@kirandasika98
Copy link

@kirandasika98 kirandasika98 commented Jan 30, 2021

@julieqiu I would like to pick up this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants