Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: 'go generate' fails to update PWD variable #43862

Closed
bcmills opened this issue Jan 22, 2021 · 2 comments
Closed

cmd/go: 'go generate' fails to update PWD variable #43862

bcmills opened this issue Jan 22, 2021 · 2 comments
Labels
NeedsFix help wanted
Milestone
Go1.17

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Jan 22, 2021 •
edited

Most subprocess invocations in the go command use base.AppendPWD to append an accurate value of PWD to the command's environment, which can speed up calls like os.Getwd and also help to provide less-confusing output from scripts.

As noted in #43724 (comment) (CC @dylan-bourque), go generate currently fails to do so when invoking the generator command:

go/src/cmd/go/internal/generate/generate.go

Line 451 in 3a778ff

cmd.Env = str.StringList(cfg.OrigEnv, g.env)

It should be updated to do so.

(CC @matloob @jayconrod)
@bcmills bcmills added help wanted NeedsFix labels Jan 22, 2021
@bcmills bcmills added this to the Backlog milestone Jan 22, 2021
@robpike
Copy link
Contributor

@robpike robpike commented Jan 22, 2021

Oh, the cursed PWD variable. An apparently simple idea with offensively wide-ranging ramifications. An object lesson in three letters for anyone paying attention.
qingyunha added a commit to qingyunha/go that referenced this issue Jan 27, 2021
@qingyunha
cmd/go: update PWD variable for 'go generate'
000fa98 
Most subprocess invocations in the go command use base.AppendPWD to
append an accurate value of PWD to the command's environment, which can
speed up calls like os.Getwd and also help to provide less-confusing
output from scripts. Update `go generate` to do so.

Fixes golang#43862

Change-Id: I3b756f1532b2d922f7d74fd86414d5567a0122c0
@qingyunha qingyunha mentioned this issue Jan 27, 2021
Closed
@gopherbot
Copy link

@gopherbot gopherbot commented Jan 27, 2021

Change https://golang.org/cl/287152 mentions this issue: cmd/go: update PWD variable for 'go generate'
qingyunha added a commit to qingyunha/go that referenced this issue Jan 28, 2021
@qingyunha
cmd/go: update PWD variable for 'go generate'
7f2a16f 
Most subprocess invocations in the go command use base.AppendPWD to
append an accurate value of PWD to the command's environment, which can
speed up calls like os.Getwd and also help to provide less-confusing
output from scripts. Update `go generate` to do so.

Fixes golang#43862

Change-Id: I3b756f1532b2d922f7d74fd86414d5567a0122c0
This was referenced Feb 3, 2021
Open
Open
@dmitshur dmitshur modified the milestones: Backlog, Go1.17 Feb 3, 2021
@bcmills bcmills mentioned this issue Feb 17, 2021
Closed
qingyunha added a commit to qingyunha/go that referenced this issue Mar 5, 2021
@qingyunha
cmd/go: update PWD variable for 'go generate'
f3c86ba 
Most subprocess invocations in the go command use base.AppendPWD to
append an accurate value of PWD to the command's environment, which can
speed up calls like os.Getwd and also help to provide less-confusing
output from scripts. Update `go generate` to do so.

Fixes golang#43862

Change-Id: I3b756f1532b2d922f7d74fd86414d5567a0122c0
qingyunha added a commit to qingyunha/go that referenced this issue Mar 5, 2021
@qingyunha
cmd/go: update PWD variable for 'go generate'
01293bf 
Most subprocess invocations in the go command use base.AppendPWD to
append an accurate value of PWD to the command's environment, which can
speed up calls like os.Getwd and also help to provide less-confusing
output from scripts. Update `go generate` to do so.

Fixes golang#43862

Change-Id: I3b756f1532b2d922f7d74fd86414d5567a0122c0
qingyunha added a commit to qingyunha/go that referenced this issue Mar 5, 2021
@qingyunha
cmd/go: update PWD variable for 'go generate'
3ec8da2 
Most subprocess invocations in the go command use base.AppendPWD to
append an accurate value of PWD to the command's environment, which can
speed up calls like os.Getwd and also help to provide less-confusing
output from scripts. Update `go generate` to do so.

Fixes golang#43862

Change-Id: I3b756f1532b2d922f7d74fd86414d5567a0122c0
@gopherbot gopherbot closed this in f0b6d37 Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix help wanted
Projects
None yet
Milestone
Go1.17
Linked pull requests

Successfully merging a pull request may close this issue.

cmd/go: update PWD variable for 'go generate'
4 participants
@dmitshur @robpike @bcmills @gopherbot