Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: .JumpDialog's position is fixed but .ShortcutsDialog is not #43877

Closed
Omkar76 opened this issue Jan 24, 2021 · 4 comments
Closed

x/pkgsite: .JumpDialog's position is fixed but .ShortcutsDialog is not #43877

Omkar76 opened this issue Jan 24, 2021 · 4 comments

Comments

@Omkar76
Copy link

@Omkar76 Omkar76 commented Jan 24, 2021

My previous PR golang/pkgsite#21 (not released) solved problem of .JumpDialog not staying on viewport but I didn't know there is one more dialogue .ShortcutsDialog which pops up on pressing ?. So basically, .JumpDialog has position:fixed and .ShortcutsDialog has position:absolute which makes it look inconsistent.

@Omkar76 Omkar76 changed the title .JumpDialog's position is fixed but .ShortcutsDialog is not x/pkgsite: .JumpDialog's position is fixed but .ShortcutsDialog is not Jan 24, 2021
@gopherbot gopherbot added the pkgsite label Jan 24, 2021
@gopherbot gopherbot added this to the Unreleased milestone Jan 24, 2021
@Omkar76
Copy link
Author

@Omkar76 Omkar76 commented Jan 24, 2021

Both dialog boxes use .Dialog class. I'll just add the position:fixed to .Dialog and remove it from '.JumpDialog`. The style will get applied to both dialogs. I'll send a PR soon.

Omkar76 added a commit to Omkar76/pkgsite that referenced this issue Jan 24, 2021
Add `position:fixed` in `.Dialog` class to make appearance of both
`.JumpDialog` and `.ShortcutsDialog consistent

Fixes golang/go#43877
Omkar76 added a commit to Omkar76/pkgsite that referenced this issue Jan 24, 2021
Add `position:fixed` in `.Dialog` class to make appearance of both
`.JumpDialog` and `ShortcutsDialog` consistent

Fixes golang/go#43877
@gopherbot
Copy link

@gopherbot gopherbot commented Jan 24, 2021

Change https://golang.org/cl/286092 mentions this issue: content/static/css: make .Dialog's position fixed

@julieqiu julieqiu modified the milestones: Unreleased, pkgsite/frontend Jan 25, 2021
@julieqiu julieqiu added the NeedsFix label Jan 25, 2021
@Omkar76
Copy link
Author

@Omkar76 Omkar76 commented Jan 25, 2021

@julieqiu, You added NeedsFix label (which I guess, means there is currently no fix provided) but I have already submitted a fix in PR golang/pkgsite#22 which corresponds to gerrit CL golang.org/cl/286092

Please have a look at it. Thank you.

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Jan 25, 2021

Per https://github.com/golang/go/wiki/Gardening:

For Go, we use the presence of certain labels (Needs* or WaitingForInfo) to indicate that an issue has been triaged.

NeedsFix indicates that the path to resolution is known, but a CL has not been submitted yet to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants