Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: construct pseudoversion for module std #43890

Closed
julieqiu opened this issue Jan 25, 2021 · 2 comments
Closed

x/pkgsite: construct pseudoversion for module std #43890

julieqiu opened this issue Jan 25, 2021 · 2 comments
Labels
NeedsInvestigation pkgsite
Milestone
pkgsite/unplanned

Comments

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Jan 25, 2021

Running go run cmd/worker/main.go and visiting http://localhost:8000/fetch/std/@v/master returns a 500 with the error:

Error (map[fetch:std@master]): Error executing fetch: FetchModule("std", "master"): stdlib.Zip("master"): getGoRepo("master"): couldn't find remote ref "refs/tags/master" (code 500)
@gopherbot gopherbot added the pkgsite label Jan 25, 2021
@gopherbot gopherbot added this to the Unreleased milestone Jan 25, 2021
@julieqiu julieqiu added NeedsInvestigation NeedsFix and removed NeedsFix labels Jan 25, 2021
@julieqiu julieqiu modified the milestones: Unreleased, pkgsite/unplanned Jan 25, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Jan 25, 2021

Change https://golang.org/cl/286153 mentions this issue: internal/stdlib: add comments on handling requests to master
gopherbot pushed a commit to golang/pkgsite that referenced this issue Jan 25, 2021
@julieqiu
internal/stdlib: fix getGoRepo for requests to master
cd0dc1f 
getGoRepo currently looks for a "master" tag when fetching the master
repo, instead of at the master branch. This is now fixed.

However, stdlib.semanticVersion still returns "master" when the
requestedVersion is "master", instead of returning a resolved semantic
version, so a fetch request for std@master will still result in a 500. A
comment is added to fix this in the future.

In a future CL, a fake pseudoversion will need to be constructed in
order to resolve std@master to a semantic version.

For golang/go#43890

Change-Id: I9e68b91d8c9e0bea6f6751d834853b852f0d532b
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/286153
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Trust: Julie Qiu <julie@golang.org>
@julieqiu julieqiu changed the title x/pkgsite: worker error when fetching std@master x/pkgsite: construct pseudoversion for module std Jan 25, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Jan 27, 2021

Change https://golang.org/cl/287213 mentions this issue: internal/stdlib: return pseudo-version for master
@gopherbot gopherbot closed this in golang/pkgsite@60eb5d7 Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@julieqiu @gopherbot