net/http: Transport memory leak #43966
Comments
wgplt
changed the title
seankhliao
changed the title
seankhliao
added
the
NeedsInvestigation
|
Just to be sure: does the problem go away when you use a new transport every time? Could you provide a full working example? |
Thanks! I'll try to use a new transport for every time! But, the comments on "transport.go(line 68)" file says: |
I use a new transport for every request, and there is no memory leak. |
|
A minimal example for reproducing would still help, preferable on go playground. |
|
I would suggest to close due to missing feedback |
|
I confirm this issue. I am getting very high usage on a reverse proxy using the http library: The solution for me was to create a single |
|
I just tracked down a similar leak. The root cause was forgetting to
I have a repro for my case attached. |
|
Had the same problem, middleware like this helped: func CloseBody(h http.Handler) http.Handler {
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
defer func() {
if r == nil || r.Body == nil {
return
}
if err := r.Body.Close(); err != nil {
fmt.Printf("closing body error: %+v\n", err)
}
}()
h.ServeHTTP(w, r)
})
}Maybe it will be helpful for people who came here with the same problem from google. So, it seems there is nothing wrong with |
What version of Go are you using (
go version)?Does this issue reproduce with the latest release?
1.15.7
What operating system and processor architecture are you using (
go env)?go envOutputWhat did you do?
I used a common "http.Transport" object for every “http.Client” HTTP request，After running for a long time, memory usage is getting higher and higher, Use pprof for debugging, as shown below：
my codes like this:
What did you expect to see?
What did you see instead?
The text was updated successfully, but these errors were encountered: