-
Notifications
You must be signed in to change notification settings - Fork 18.3k
Closed
Labels
FrozenDueToAgeNeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Description
What version of Go are you using (go version
)?
$ go version go version go1.16rc1 linux/amd64
Does this issue reproduce with the latest release?
no.
reproduced on 1.16rc1
What operating system and processor architecture are you using (go env
)?
go env
Output
$ go env GO111MODULE="" GOARCH="amd64" GOBIN="" GOCACHE="/home/heijo/.cache/go-build" GOENV="/home/heijo/.config/go/env" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="linux" GOINSECURE="" GOMODCACHE="/home/heijo/go/pkg/mod" GONOPROXY="" GONOSUMDB="" GOOS="linux" GOPATH="/home/heijo/go" GOPRIVATE="" GOPROXY="https://proxy.golang.org,direct" GOROOT="/home/heijo/ghq/go.googlesource.com/go" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/home/heijo/ghq/go.googlesource.com/go/pkg/tool/linux_amd64" GOVCS="" GOVERSION="go1.16rc1" GCCGO="gccgo" AR="ar" CC="gcc" CXX="g++" CGO_ENABLED="1" GOMOD="/home/heijo/ghq/go.googlesource.com/go/src/go.mod" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build3979720791=/tmp/go-build -gno-record-gcc-switches"
What did you do?
I was investigating changes in the behavior of the http.cookie samesite in 1.16.
package main
import (
"net/http"
"net/http/httptest"
"testing"
)
func TestSameSiteDefaultMode(t *testing.T) {
handler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
http.SetCookie(w, &http.Cookie{Name: "n", Value: "v", SameSite: http.SameSiteDefaultMode})
})
req := httptest.NewRequest(http.MethodGet, "/", nil)
rec := httptest.NewRecorder()
handler.ServeHTTP(rec, req)
resp := rec.Result()
got := resp.Cookies()[0].SameSite
if got != http.SameSiteDefaultMode {
t.Errorf("shoud be default mode (%v) but got %v", http.SameSiteDefaultMode, got)
}
}
What did you expect to see?
pass test
On 1.15.7, pass
What did you see instead?
On 1.16rc1 fails
--- FAIL: TestSameSiteDefaultMode (0.00s)
main_test.go:20: shoud be default mode (1) but got 0
FAIL
exit status 1
ichizero
Metadata
Metadata
Assignees
Labels
FrozenDueToAgeNeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.