Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: anchor link heading obscured by top banner in Safari #43999

Open
myitcv opened this issue Jan 29, 2021 · 1 comment
Open

x/pkgsite: anchor link heading obscured by top banner in Safari #43999

myitcv opened this issue Jan 29, 2021 · 1 comment

Comments

@myitcv
Copy link
Member

@myitcv myitcv commented Jan 29, 2021

What is the URL of the page with the issue?

https://pkg.go.dev/crypto@go1.15.6#PublicKey

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.1.2 Safari/605.1.15

Screenshot

Screen Shot 2021-01-29 at 20 11 32

What did you do?

Visited the above link using Safari

What did you expect to see?

The heading in the anchor link, per Chrome:

Screen Shot 2021-01-29 at 20 12 32

What did you see instead?

The heading obscured by the top banner:

Screen Shot 2021-01-29 at 20 11 32

cc @mpvl

@jamalc
Copy link
Member

@jamalc jamalc commented Jan 29, 2021

This is a known issue with WebKit based browsers. The WebKit team has released a fix and it is available in the WebKit Nightly Build. I'd prefer to wait for the next Safari release over making a Safari specific fix for this feature. We can leave this open for tracking purposes.

@jba jba modified the milestones: Unreleased, pkgsite/unplanned Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants