Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: add support for plain text interface #44029

Open
Zamony opened this issue Jan 31, 2021 · 3 comments
Open

x/pkgsite: add support for plain text interface #44029

Zamony opened this issue Jan 31, 2021 · 3 comments

Comments

@Zamony
Copy link

@Zamony Zamony commented Jan 31, 2021

As far as I can tell pkg.go.dev doesn't support this feature either
https://github.com/golang/gddo/wiki/Plain-Text-Interface

What did you do?

curl -H 'Accept: text/plain' https://godoc.org/math

What did you expect to see?

Plain text representation of math package

What did you see instead?

<a href="https://pkg.go.dev/search?q=sql&amp;utm_source=godoc">Found</a>.

@seankhliao seankhliao changed the title Godoc plain text interface is not working godoc.org: plain text interface not working Jan 31, 2021
@seankhliao
Copy link
Contributor

@seankhliao seankhliao commented Jan 31, 2021

due to #43178

cc @julieqiu

@fzipp
Copy link
Contributor

@fzipp fzipp commented Jan 31, 2021

I noticed this too when gofind stopped working. It used godoc.org's plain text interface, and I updated it to scrape pkg.go.dev's search results HTML page for now - until pkg.go.dev gets an API (#36785).

@julieqiu julieqiu changed the title godoc.org: plain text interface not working x/pkgsite: add support for plain text interface Feb 2, 2021
@julieqiu julieqiu added this to the pkgsite/unplanned milestone Feb 2, 2021
@gopherbot gopherbot removed this from the pkgsite/unplanned milestone Feb 2, 2021
@gopherbot gopherbot added this to the Unreleased milestone Feb 2, 2021
@jamalc jamalc removed this from the Unreleased milestone Feb 2, 2021
@jamalc jamalc added this to the pkgsite/godoc.org-redirect milestone Feb 2, 2021
@julieqiu julieqiu removed this from the pkgsite/godoc.org-redirect milestone Feb 2, 2021
@julieqiu julieqiu added this to the pkgsite/unplanned milestone Feb 2, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Feb 2, 2021

Change https://golang.org/cl/288949 mentions this issue: gddo-server: do not redirect plain text requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants