Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: expand all should be collapse all when all directories are expanded #44072

Open
julieqiu opened this issue Feb 2, 2021 · 2 comments
Open

Comments

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Feb 2, 2021

What is the URL of the page with the issue?

https://pkg.go.dev/cloud.google.com/go@v0.76.0#section-directories

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 11_1_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.96 Safari/537.36

Screenshot

image

What did you do?

Clicked "Expand all"

What did you expect to see?

"Expand all" to change to "Collapse all"

What did you see instead?

"Expand all" without option to collapse.

/cc @jamalc

@gopherbot gopherbot added the pkgsite label Feb 2, 2021
@gopherbot gopherbot added this to the Unreleased milestone Feb 2, 2021
@julieqiu julieqiu added NeedsFix pkgsite and removed pkgsite labels Feb 2, 2021
@julieqiu
Copy link
Contributor Author

@julieqiu julieqiu commented Feb 2, 2021

The "Expand all" toggle can also be omitted when there is nothing to expand. For example, on https://pkg.go.dev/net/http@go1.15.6#section-directories:

image

@jamalc jamalc added the help wanted label Feb 2, 2021
@Olament
Copy link

@Olament Olament commented Feb 4, 2021

I am wondering what state the "expanding all" button should be when only some of the directories are expanded. Also, Do you expect the "expanding all" button changes to "collapse all" if I manually expanded all the directories?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants