Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: add dependency suggested fix broken with experimentalWorkspaceModule #44132

Closed
stamblerre opened this issue Feb 6, 2021 · 1 comment

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Feb 6, 2021

Similar to the go mod tidy and update go.sum quick fixes, the add dependency quick fix does not work in experimental workspace module mode. The issue is again that we don't associate the fix with the correct module, which can lead to unpredictable results.

@stamblerre stamblerre added this to the gopls/v0.6.6 milestone Feb 6, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Feb 11, 2021

Change https://golang.org/cl/291192 mentions this issue: internal/lsp: refactor go command error handling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants