Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: Ambigous error message in dnsclient #44208

Open
synergiator opened this issue Feb 10, 2021 · 2 comments
Open

net: Ambigous error message in dnsclient #44208

synergiator opened this issue Feb 10, 2021 · 2 comments

Comments

@synergiator
Copy link

@synergiator synergiator commented Feb 10, 2021

There is an issue with the Golang DNS client implementation:

errServerMisbehaving         = errors.New("server misbehaving")
errServerTemporarilyMisbehaving = errors.New("server misbehaving")
  • Different error scenarios based on 2 variables lead to same ambiguous error message
  • "Misbehaving" is an ambiguous word itself: to the possible extent, it should be clear what has actually happened i.e. print out DNS protocol error.
@synergiator synergiator changed the title net/dnsclient Ambigous error messages in net/dnsclient Feb 10, 2021
@synergiator synergiator changed the title Ambigous error messages in net/dnsclient Ambigous error message in net/dnsclient Feb 10, 2021
@seankhliao seankhliao changed the title Ambigous error message in net/dnsclient net: Ambigous error message in dnsclient Feb 10, 2021
@seankhliao
Copy link
Contributor

@seankhliao seankhliao commented Feb 10, 2021

Is this really a problem when it is never exposed to the client and only used to set the IsTemporary field in DNSError ?

ref: https://golang.org/src/net/dnsclient_unix.go#L281

@synergiator
Copy link
Author

@synergiator synergiator commented Feb 10, 2021

in Docker client error messages, it seems like you can see it exposed:

Get "https://production.cloudflare.docker.com ... tcp: lookup production.cloudflare.docker.com 
on ...: server misbehaving

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants