Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: support viewing the standard library @master #44390

Closed
julieqiu opened this issue Feb 18, 2021 · 4 comments
Closed

x/pkgsite: support viewing the standard library @master #44390

julieqiu opened this issue Feb 18, 2021 · 4 comments
Assignees
Labels

Comments

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Feb 18, 2021

It would be useful to view https://pkg.go.dev/std@master. This issue was originally opened in #39973.

At the moment, when running the worker and visiting http://localhost:8000/fetch/std/@v/master, this error shows up in the version_map table:

fetchAndInsertModule("std", "master"): FetchModule("std", "master"): processZipFile("std", "v0.0.0-20210218181204-f3c2208e2cca"): extractPackagesFromZip(ctx, "std", "v0.0.0-20210218181204-f3c2208e2cca", r, d): expected file to have prefix "std@v0.0.0-20210218181204-f3c2208e2cca/"; got = "std@master/AUTHORS": module zip is malformed: bad module

@gopherbot
Copy link

@gopherbot gopherbot commented Feb 22, 2021

Change https://golang.org/cl/294831 mentions this issue: internal/stdlib: fix Zip for master version

gopherbot pushed a commit to golang/pkgsite that referenced this issue Feb 22, 2021
An error is fixed when creating the zipfile for std@master, which
prevented the module from being fetched. A test is also added.

For golang/go#44390

Change-Id: I279146aef10311822f47f16259a2223c879140c2
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/294831
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
@gopherbot
Copy link

@gopherbot gopherbot commented Feb 22, 2021

Change https://golang.org/cl/294350 mentions this issue: internal/postgres,worker: schedule fetching of std@master

@gopherbot
Copy link

@gopherbot gopherbot commented Feb 22, 2021

Change https://golang.org/cl/294832 mentions this issue: internal/frontend: enable requests to std@master

gopherbot pushed a commit to golang/pkgsite that referenced this issue Feb 22, 2021
In order to ensure that pkg.go.dev/std@master is always showing the
latest version, an endpoint is added which checks for the most recent
version of std@master. If the version in our database is not up to date,
a fetch request is scheduled.

Additionally, since only the most recent pseudoversion of std is ever
shown on pkg.go.dev, older versions are deleted.

For golang/go#44390

Change-Id: Iad56b8653f378fb5a7d72a1e30505da090de279d
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/294350
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
gopherbot pushed a commit to golang/pkgsite that referenced this issue Feb 23, 2021
Requests to pkg.go.dev/std@master are now supported.

For golang/go#44390

Change-Id: Ie64ea679bfe855aa690004bf6effd7be424aa5dc
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/294832
Trust: Julie Qiu <julie@golang.org>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
@julieqiu
Copy link
Contributor Author

@julieqiu julieqiu commented Feb 23, 2021

Requests to https://pkg.go.dev/std@master are now supported.

@julieqiu julieqiu closed this Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants