Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: windows mkMode should set 0111 for dirs #4444

Closed
rsc opened this issue Nov 26, 2012 · 5 comments
Closed

os: windows mkMode should set 0111 for dirs #4444

rsc opened this issue Nov 26, 2012 · 5 comments
Assignees
Milestone

Comments

@rsc
Copy link
Contributor

@rsc rsc commented Nov 26, 2012

mkMode returns mode 0444 or 0666 for directories on Windows. It should set the 0111 bits
too, for consistency with Unix modes. (If we're going to simulate them the simulation
should be more faithful.)

The current behavior leads to strange behaviors like creating zip files from Windows
with directories mode 0666, which then means that when unzipped on Unix the directories
are unusable.
@alexbrainman

This comment has been minimized.

Copy link
Member

@alexbrainman alexbrainman commented Nov 27, 2012

Comment 1:

http://golang.org/cl/6858079/

Status changed to Started.

@alexbrainman

This comment has been minimized.

Copy link
Member

@alexbrainman alexbrainman commented Nov 28, 2012

Comment 2:

This issue was closed by revision 5b65023.

Status changed to Fixed.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 29, 2012

Comment 3:

The permissions on my Linux machine of directory src/pkg/os are 0400. os_test.go fails
with the following message:
--- FAIL: TestStatDirModeExec-2 (0.00 seconds)
os_test.go:1107:        Stat ".": mode 020000000700 want 0111
FAIL
@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Nov 30, 2012

Comment 4:

Open a new bug and link it here.
@alexbrainman

This comment has been minimized.

Copy link
Member

@alexbrainman alexbrainman commented Nov 30, 2012

Comment 5:

How about this https://golang.org/cl/6851129/ ?
Alex
@rsc rsc added fixed labels Nov 30, 2012
@rsc rsc self-assigned this Nov 30, 2012
@rsc rsc added this to the Go1.1 milestone Apr 14, 2015
@rsc rsc removed the go1.1 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.