x/exp/cmd/gorelease: cannot process package _test files #44440
When I add a test file like:
package my_test //...
in a sample module:
module github.com/user/repo // ...
I can confirm that I did not remove
The text was updated successfully, but these errors were encountered:
I did some debugging and found the cause: cyclic imports are not considered in
I actually ran into this independently in https://go-review.googlesource.com/c/exp/+/288032, funnily enough.
Why is this happening:
In the provided repro, there's a module cycle:
Well, when we run
So anyways, the code above basically ignores anything with the same modPath as the base module when doing the
I'll work on getting a test out for this, and a better solution.
@jayconrod , let me know if you can think of a nicer way to tackle this than my proposal above. It's late on a Friday so I may be missing something obvious. :)