Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/gofmt: using different versions of gofmt across the user base can lead to gofmt races #4446

Closed
griesemer opened this issue Nov 26, 2012 · 3 comments

Comments

@griesemer
Copy link
Contributor

@griesemer griesemer commented Nov 26, 2012

issue #4428 reported a "race"  where alignment of fields is going back and
forth over time.

This is likely due to different - and not up-to-date - versions of gofmt being used for
submits. Possibly because some people use the released version while others use tip.

We should enforce that code is gofmt-ed with the most up-to-date version (or a fixed
version) of gofmt before submitting (perhaps we can allow a small sliding window).
@rsc
Copy link
Contributor

@rsc rsc commented Dec 9, 2012

Comment 1:

Labels changed: added priority-later, removed priority-triage.

@rsc
Copy link
Contributor

@rsc rsc commented Dec 9, 2012

Comment 2:

This seems to be working fine as is. 
It is true that people have to agree about which gofmt to use - tip or Go 1.0 for
example - and we could check this in our repo, but we're not having any problems with
this.
It's a bigger deal for external repos, where people might be working on them using Go
1.0 or using tip. But we don't have any control over that.
Perhaps a better fix is to declare gofmt's output done and reject future changes to
spacing.
Removing Go1.1 label but honestly I think this could just be closed as Unfortunate.

Labels changed: removed go1.1.

@rsc
Copy link
Contributor

@rsc rsc commented Jul 30, 2013

Comment 3:

Status changed to Unfortunate.

@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.