Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
cmd/gofmt: using different versions of gofmt across the user base can lead to gofmt races #4446
issue #4428 reported a "race" where alignment of fields is going back and forth over time. This is likely due to different - and not up-to-date - versions of gofmt being used for submits. Possibly because some people use the released version while others use tip. We should enforce that code is gofmt-ed with the most up-to-date version (or a fixed version) of gofmt before submitting (perhaps we can allow a small sliding window).
This seems to be working fine as is. It is true that people have to agree about which gofmt to use - tip or Go 1.0 for example - and we could check this in our repo, but we're not having any problems with this. It's a bigger deal for external repos, where people might be working on them using Go 1.0 or using tip. But we don't have any control over that. Perhaps a better fix is to declare gofmt's output done and reject future changes to spacing. Removing Go1.1 label but honestly I think this could just be closed as Unfortunate.
Labels changed: removed go1.1.