Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: add the unusedwrite analysis #44461

Closed
ainar-g opened this issue Feb 20, 2021 · 4 comments
Closed

x/tools/gopls: add the unusedwrite analysis #44461

ainar-g opened this issue Feb 20, 2021 · 4 comments
Labels
Milestone

Comments

@ainar-g
Copy link
Contributor

@ainar-g ainar-g commented Feb 20, 2021

CL 287034 added the new unusedwrite analysis pass. I think it would be nice to have in gopls.

I'm not sure if it should be among the default analysers, but either way, if there are no objections to this, I am ready to send a CL.

@gopherbot gopherbot added this to the Unreleased milestone Feb 20, 2021
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v1.0.0 Feb 20, 2021
@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Feb 23, 2021

We'd be happy to accept a CL--if you think it should be off by default, we can start with that first, and then enable it later on?

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Feb 23, 2021

Ah, looks like it uses SSA, so let's keep it off by default to start.

@gopherbot
Copy link

@gopherbot gopherbot commented Feb 23, 2021

Change https://golang.org/cl/295172 mentions this issue: internal/lsp/source: add the unusedwrite analyzer

@ainar-g
Copy link
Contributor Author

@ainar-g ainar-g commented Feb 23, 2021

Thanks for reviewing!

@stamblerre stamblerre modified the milestones: gopls/v1.0.0, gopls/v0.6.7 Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants