Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: "internal compiler error: arg 1 does not dominate" with ssacheck on #44465

Closed
ALTree opened this issue Feb 20, 2021 · 3 comments
Closed

Comments

@ALTree
Copy link
Member

@ALTree ALTree commented Feb 20, 2021

go version go1.15.8 linux/amd64
go version go1.16 linux/amd64
go version devel +d4b2638234 Sat Feb 20 03:54:50 2021 +0000 linux/amd64
package p

func f() {
	var b bool
	if b {
		b = true
	}
l:
	for !b {
		b = true
		goto l
	}
}
$ go tool compile -d=ssa/check/seed crash.go 
crash.go:5:2: internal compiler error: 'f': arg 1 of value v7 = Phi <mem> v1 v7 does not dominate, arg=v7 = Phi <mem> v1 v7
@ALTree ALTree added this to the Go1.17 milestone Feb 20, 2021
@randall77
Copy link
Contributor

@randall77 randall77 commented Feb 20, 2021

This looks like a shortcircuit bug. @josharian this looks like it was introduced at CL 222923.

Loading

@josharian
Copy link
Contributor

@josharian josharian commented Feb 20, 2021

@ALTree you always have the best CFGs. I’m AFK possibly until Monday but will fix ASAP. Likely to be a very simple, targeted fix.

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Feb 22, 2021

Change https://golang.org/cl/295130 mentions this issue: cmd/compile: reject some rare looping CFGs in shortcircuit

Loading

@gopherbot gopherbot closed this in 0490347 Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants