Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: be more strict in matching diagnostics and quick fixes in regression tests #44644

Open
stamblerre opened this issue Feb 26, 2021 · 0 comments

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Feb 26, 2021

Currently, regression tests allow you to match on a single diagnostic in a file without specifying its message. This can lead to us matching the wrong diagnostic or applying the wrong quick fixes.

Whenever we wait for diagnostics, we should wait for all of the diagnostics in the file to ensure we're not producing duplicates or new diagnostics. We should also always require the diagnostic message in all cases.

Finally, we should require a single diagnostic when we apply quick fixes, instead of applying all of the quick fixes available.

/cc @heschik

@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Feb 26, 2021
@stamblerre stamblerre added this to To Do in gopls on-deck Feb 28, 2021
@stamblerre stamblerre moved this from To Do to P3 in gopls on-deck Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants